Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CUB tunings to dedicated headers #3097

Closed
8 tasks done
bernhardmgruber opened this issue Dec 9, 2024 · 0 comments · Fixed by #3141
Closed
8 tasks done

Move CUB tunings to dedicated headers #3097

bernhardmgruber opened this issue Dec 9, 2024 · 0 comments · Fixed by #3141
Assignees
Labels
cub For all items related to CUB

Comments

@bernhardmgruber
Copy link
Contributor

bernhardmgruber commented Dec 9, 2024

All CUB algorithms have tunings they select via the policy hub, but they are sometimes placed in the dispatcher implementation header (e.g. cub/device/dispatch/dispatch_radix_sort.cuh) and sometimes in dedicated tuning headers (e.g. cub/device/dispatch/tuning/tuning_radix_sort.cuh).

We should finish the effort @gevtushenko started a while back and move all policy hubs and tunings to dedicated headers. This makes the files a bit more maintainable, especially during tuning when we have to extend the policy hub with new tunings.

Applies to the folloing CUB algos:

  • adjacent_difference
  • batch_memcpy
  • merge
  • merge_sort
  • reduce
  • radix_sort
  • segmented_sort
  • transform
@github-project-automation github-project-automation bot moved this to Todo in CCCL Dec 9, 2024
@bernhardmgruber bernhardmgruber added the cub For all items related to CUB label Dec 9, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Dec 12, 2024
bernhardmgruber added a commit that referenced this issue Dec 12, 2024
* Move merge policy hub to tuning header
* Move merge_sort policy hub to tuning header
* Move reduce policy hub to tuning header
* Move segmented_sort policy hub to tuning header
* Move transform policy hub to tuning header

Fixes: #3097
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cub For all items related to CUB
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants