Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend cuda::std::numeric_limits for __half, __nv_bfloat16, __nv_fp8_e4m3, __nv_fp8_e5m2 #3349

Closed
Tracked by #101
bernhardmgruber opened this issue Jan 10, 2025 · 5 comments
Closed
Tracked by #101

Extend cuda::std::numeric_limits for __half, __nv_bfloat16, __nv_fp8_e4m3, __nv_fp8_e5m2 #3349

bernhardmgruber opened this issue Jan 10, 2025 · 5 comments
Assignees
@bernhardmgruber

Comments

@bernhardmgruber
Copy link
Contributor

bernhardmgruber commented Jan 10, 2025 •
edited
Loading

Part of this is covered here: #525
@bernhardmgruber bernhardmgruber mentioned this issue Jan 10, 2025
Open
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jan 10, 2025
@davebayer davebayer mentioned this issue Jan 12, 2025
Merged
@bernhardmgruber bernhardmgruber mentioned this issue Jan 12, 2025
Open
9 tasks
@fbusato
Copy link
Contributor

fbusato commented Jan 13, 2025

would make sense to also add the following functions for completeness?

  • isfinite
  • isinf
  • isnan
  • isnormal
  • signbit

(@davebayer for visibility)

@miscco
Copy link
Collaborator

miscco commented Jan 14, 2025

Can we split __nv_fp8_e4m3 and __nv_fp8_e5m2 into their separate issue because we currently do not support them at all in libcu++

@bernhardmgruber
Copy link
Contributor Author

would make sense to also add the following functions for completeness?

  • isfinite
  • isinf
  • isnan
  • isnormal
  • signbit

Eventually yes, but I don't need them to deprecate/replace cub::Traits, so they are less urgent IMO.

@fbusato
Copy link
Contributor

fbusato commented Jan 27, 2025

@bernhardmgruber can we close this issue after #3478?

@bernhardmgruber bernhardmgruber self-assigned this Jan 28, 2025
@bernhardmgruber bernhardmgruber changed the title Extend cuda::std::numeric_limits for __half, __nv_bfloat16, __nv_fp8_e4m3, __nv_fp8_e5m2 and deprecate cub::FpLimits Extend cuda::std::numeric_limits for __half, __nv_bfloat16, __nv_fp8_e4m3, __nv_fp8_e5m2 Jan 28, 2025
@bernhardmgruber
Copy link
Contributor Author

The FP8 and FP16 support is all implemented. I removed deprecating cub::FpTraits from this issue, because that will be deprecated as part of cub::Traits in #3381

@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bernhardmgruber bernhardmgruber

Labels
None yet
Projects
CCCL
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bernhardmgruber @miscco @fbusato