Ensure cuda/stream_ref can be used without a CUDA compiler #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
Closed
1 task
|
/ok to test |
bdice
reviewed
Jan 21, 2025
| throw ::std::runtime_error("Failed to query stream."); | ||
| # else | ||
| ::std::terminate(); | ||
| # else |
There was a problem hiding this comment.
This seems like a typo. This change is needed to make builds succeed for me.
Suggested change
| # else | |
| # endif |
There was a problem hiding this comment.
I'm puzzled why this wasn't caught in CI, we are indeed not testing non-CUDA compilers at all .... Maybe we are not reaching that path anymore due to other PR now avoiding to include this header earlier if we are not in a CUDA compiler ?
bdice
reviewed
Jan 21, 2025
| @@ -9,7 +9,7 @@ | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #ifndef _CUDA_STREAM_REF | |||
| #define _CUDA_STREAM_REF | |||
| # define _CUDA_STREAM_REF | |||
There was a problem hiding this comment.
Do we need to indent all these macros? I would prefer to leave those unchanged in this PR.
There was a problem hiding this comment.
Isn't that some effect of a recent clang-format update ?
|
I think this issue is fixed by #3472. @caugonnet Feel free to close if you agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing
::cuda::__throw_cuda_errorwithout a CUDA compiler has some challenging, so instead we make it possible to include cuda/stream_ref without itChecklist