Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Improve cuda/std/cmath to build without depending on the relaxed constexpr build option #3371

Closed
1 task done
PointKernel opened this issue Jan 13, 2025 · 4 comments
Labels
bug Something isn't working right.

Comments

@PointKernel
Copy link
Member

PointKernel commented Jan 13, 2025

Is this a duplicate?

Type of Bug

Compile-time Error

Component

libcu++

Describe the bug

While working on building libcudf without enabling the relaxed constexpr option (rapidsai/cudf#7795), I observed that several
cuda/std/cmath utilities cannot be built without relying on the relaxed constexpr option.

How to Reproduce

See https://godbolt.org/z/f5ebG1Wxz

Expected behavior

The above godbolt should work without errors

Reproduction link

https://godbolt.org/z/f5ebG1Wxz

@PointKernel PointKernel added the bug Something isn't working right. label Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jan 13, 2025
@miscco
Copy link
Collaborator

miscco commented Jan 14, 2025

Yeah that is an unfortunate historical artefact. We started properly implementing all the math functions, but it is a ... process

@PointKernel
Copy link
Member Author

@miscco Thanks for getting the PR up so quickly!

Quick question: Will the corresponding PR make cuda::std::ceil a constexpr when building with NVCC 11.8?
https://godbolt.org/z/94nYnvqMW

@miscco
Copy link
Collaborator

miscco commented Jan 14, 2025

Need to check whether the compiler supports it but my guess is no

@miscco miscco closed this as completed Jan 16, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Jan 16, 2025
@miscco
Copy link
Collaborator

miscco commented Jan 16, 2025

Merged the fixes, those functions should now be available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Archived in project
Development

No branches or pull requests

2 participants