Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing visibility annotations to ustdex types that have data members #3571

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ericniebler
Copy link
Collaborator

Description

This should fix the build break seen by @alliepiper on #3544 and unblock the switch to use CTK 12.8 in CI

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ericniebler ericniebler requested a review from a team as a code owner January 28, 2025 19:23
@ericniebler ericniebler marked this pull request as draft January 28, 2025 19:25
Copy link

copy-pr-bot bot commented Jan 28, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on 12.8, fixes the issue 🙂

@alliepiper alliepiper marked this pull request as ready for review January 28, 2025 20:05
@alliepiper alliepiper enabled auto-merge (squash) January 28, 2025 20:05
Copy link
Contributor

🟩 CI finished in 7h 44m: Pass: 100%/20 | Total: 1h 54m | Avg: 5m 44s | Max: 18m 04s | Hits: 327%/522
  • 🟩 cudax: Pass: 100%/20 | Total: 1h 54m | Avg: 5m 44s | Max: 18m 04s | Hits: 327%/522

    🟩 cpu
      🟩 amd64              Pass: 100%/16  | Total:  1h 42m | Avg:  6m 25s | Max: 18m 04s | Hits: 327%/522   
      🟩 arm64              Pass: 100%/4   | Total: 12m 09s | Avg:  3m 02s | Max:  3m 12s
    🟩 ctk
      🟩 12.0               Pass: 100%/1   | Total:  9m 21s | Avg:  9m 21s | Max:  9m 21s | Hits: 327%/261   
      🟩 12.5               Pass: 100%/2   | Total: 12m 15s | Avg:  6m 07s | Max:  6m 15s
      🟩 12.6               Pass: 100%/17  | Total:  1h 33m | Avg:  5m 29s | Max: 18m 04s | Hits: 327%/261   
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/1   | Total:  9m 21s | Avg:  9m 21s | Max:  9m 21s | Hits: 327%/261   
      🟩 nvcc12.5           Pass: 100%/2   | Total: 12m 15s | Avg:  6m 07s | Max:  6m 15s
      🟩 nvcc12.6           Pass: 100%/17  | Total:  1h 33m | Avg:  5m 29s | Max: 18m 04s | Hits: 327%/261   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/20  | Total:  1h 54m | Avg:  5m 44s | Max: 18m 04s | Hits: 327%/522   
    🟩 cxx
      🟩 Clang14            Pass: 100%/1   | Total:  3m 27s | Avg:  3m 27s | Max:  3m 27s
      🟩 Clang15            Pass: 100%/1   | Total:  3m 34s | Avg:  3m 34s | Max:  3m 34s
      🟩 Clang16            Pass: 100%/1   | Total:  3m 25s | Avg:  3m 25s | Max:  3m 25s
      🟩 Clang17            Pass: 100%/1   | Total:  3m 28s | Avg:  3m 28s | Max:  3m 28s
      🟩 Clang18            Pass: 100%/4   | Total: 27m 45s | Avg:  6m 56s | Max: 18m 04s
      🟩 GCC10              Pass: 100%/1   | Total:  3m 31s | Avg:  3m 31s | Max:  3m 31s
      🟩 GCC11              Pass: 100%/1   | Total:  3m 23s | Avg:  3m 23s | Max:  3m 23s
      🟩 GCC12              Pass: 100%/2   | Total: 19m 59s | Avg:  9m 59s | Max: 16m 17s
      🟩 GCC13              Pass: 100%/4   | Total: 11m 59s | Avg:  2m 59s | Max:  3m 12s
      🟩 MSVC14.36          Pass: 100%/1   | Total:  9m 21s | Avg:  9m 21s | Max:  9m 21s | Hits: 327%/261   
      🟩 MSVC14.39          Pass: 100%/1   | Total: 12m 50s | Avg: 12m 50s | Max: 12m 50s | Hits: 327%/261   
      🟩 NVHPC24.7          Pass: 100%/2   | Total: 12m 15s | Avg:  6m 07s | Max:  6m 15s
    🟩 cxx_family
      🟩 Clang              Pass: 100%/8   | Total: 41m 39s | Avg:  5m 12s | Max: 18m 04s
      🟩 GCC                Pass: 100%/8   | Total: 38m 52s | Avg:  4m 51s | Max: 16m 17s
      🟩 MSVC               Pass: 100%/2   | Total: 22m 11s | Avg: 11m 05s | Max: 12m 50s | Hits: 327%/522   
      🟩 NVHPC              Pass: 100%/2   | Total: 12m 15s | Avg:  6m 07s | Max:  6m 15s
    🟩 gpu
      🟩 v100               Pass: 100%/20  | Total:  1h 54m | Avg:  5m 44s | Max: 18m 04s | Hits: 327%/522   
    🟩 jobs
      🟩 Build              Pass: 100%/18  | Total:  1h 20m | Avg:  4m 28s | Max: 12m 50s | Hits: 327%/522   
      🟩 Test               Pass: 100%/2   | Total: 34m 21s | Avg: 17m 10s | Max: 18m 04s
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  2m 53s | Avg:  2m 53s | Max:  2m 53s
      🟩 90a                Pass: 100%/1   | Total:  3m 02s | Avg:  3m 02s | Max:  3m 02s
    🟩 std
      🟩 17                 Pass: 100%/4   | Total: 15m 02s | Avg:  3m 45s | Max:  6m 15s
      🟩 20                 Pass: 100%/16  | Total:  1h 39m | Avg:  6m 14s | Max: 18m 04s | Hits: 327%/522   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 20)

# Runner
12 linux-amd64-cpu16
4 linux-arm64-cpu16
2 windows-amd64-cpu16
2 linux-amd64-gpu-v100-latest-1

@alliepiper alliepiper merged commit 2a03b6e into NVIDIA:main Jan 29, 2025
37 of 40 checks passed
davebayer pushed a commit to davebayer/cccl that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants