-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn TEST_[HALF|BF]_T
into function-style macros and fix some tests
#3608
Turn TEST_[HALF|BF]_T
into function-style macros and fix some tests
#3608
Conversation
d8014bf
to
0683e24
Compare
c2h/include/c2h/extended_types.h
Outdated
# if defined(_CCCL_HAS_NVFP16) && defined(_LIBCUDACXX_HAS_NVFP16) | ||
# define TEST_HALF_T() 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_CCCL_HAS_NVFP16
only tells us that the CTK headers are present, but _LIBCUDACXX_HAS_NVFP16
is needed to know that libcu++ also provides traits, limits, etc. on host and device.
269dfbe
to
183e65c
Compare
🟨 CI finished in 1h 12m: Pass: 96%/89 | Total: 1d 11h | Avg: 24m 05s | Max: 54m 19s | Hits: 411%/10018
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 89)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
8 | windows-amd64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
4 | linux-arm64-cpu16 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
2 | linux-amd64-gpu-rtx2080-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
🟩 CI finished in 1h 11m: Pass: 100%/89 | Total: 15h 24m | Avg: 10m 23s | Max: 37m 25s | Hits: 421%/10896
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 89)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
8 | windows-amd64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
4 | linux-arm64-cpu16 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
2 | linux-amd64-gpu-rtx2080-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
2ba33b3
to
28501e0
Compare
Temporarily switching back to testing FP16 types when CTK headers are available, since #3535 may change the game. |
/ok to test |
TEST_[HALF|BF]_T
into function-style macros and fix some tests
🟩 CI finished in 1h 12m: Pass: 100%/89 | Total: 1d 00h | Avg: 16m 16s | Max: 1h 04m | Hits: 402%/10896
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 89)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
8 | windows-amd64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
4 | linux-arm64-cpu16 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
2 | linux-amd64-gpu-rtx2080-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
Backport failed for Please cherry-pick the changes locally. git fetch origin branch/2.8.x
git worktree add -d .worktree/backport-3608-to-branch/2.8.x origin/branch/2.8.x
cd .worktree/backport-3608-to-branch/2.8.x
git checkout -b backport-3608-to-branch/2.8.x
ancref=$(git merge-base 3e47ee8fd4313f30757332335e621716bd62c40d 28501e0b69403f183e8655ee3f33fd98236222b2)
git cherry-pick -x $ancref..28501e0b69403f183e8655ee3f33fd98236222b2 |
I decided against backporting this PR, because bug fixes (some tests checking a macro wrongly and thus always being disabled) could turn up more work on old compilers :) |
This is pulled out from #3384 and paves the way for some future changes. The
TEST_HALF_T
andTEST_BF_T
macros are changed to function-style macros and some tests are fixes, which checked with#ifdef TEST_HALF_H
but forgot to include a header that defined the macros.