-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aws-sdk-cpp. #2362
Open
schweitzpgi
wants to merge
10
commits into
NVIDIA:main
Choose a base branch
from
schweitzpgi:ch-fix.braket
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove aws-sdk-cpp. #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
force-pushed
the
ch-fix.braket
branch
from
November 7, 2024 15:47
bff55ba
to
5875460
Compare
schweitzpgi
force-pushed
the
ch-fix.braket
branch
2 times, most recently
from
November 7, 2024 20:40
22ffe45
to
085904b
Compare
schweitzpgi
force-pushed
the
ch-fix.braket
branch
3 times, most recently
from
November 21, 2024 23:00
31ee515
to
4159b0a
Compare
boschmitt
reviewed
Nov 22, 2024
schweitzpgi
force-pushed
the
ch-fix.braket
branch
from
November 22, 2024 22:47
4159b0a
to
e1b2591
Compare
schweitzpgi
force-pushed
the
ch-fix.braket
branch
from
November 25, 2024 17:05
2b96487
to
2cc80f8
Compare
schweitzpgi
force-pushed
the
ch-fix.braket
branch
from
November 26, 2024 21:04
d6a0387
to
7279627
Compare
The building of this backend needs to be made such that it is opt-in with a cmake command line variable setting. Building the aws-sdk-cpp code itself ought to be done as a prereq and not at project build time. Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
prereq build script. Put in skeleton for building aws-sdk-cpp. Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
schweitzpgi
force-pushed
the
ch-fix.braket
branch
from
November 26, 2024 22:55
7279627
to
52a8d40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The building of this backend needs to be made such that it is opt-in with a cmake command line variable setting. Building the aws-sdk-cpp code itself ought to be done as a prereq and not at project build time.
This patch is expected to fail because it doesn't fix the build scripts.