Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support measurement sampling seed for cutensornet backends #2398

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Support measurement sampling seed for cutensornet backends #2398

merged 8 commits into from
Nov 27, 2024

Conversation

1tnguyen
Copy link
Collaborator

Description

  • This support has been added in cutensornet v2.5.

  • Majority of the code change is to propagate the Simulator-level random engine to all the State classes. These are references to the single instance at the backend level, which is seeded by the cudaq runtime.

  • Re-enable the test that was skipped due to the lack of this support.

Fixed #895

Test results of the re-enabled tests:

   Start 461: tensornet_GHZSampleTester.checkBroadcastRepeatability
5/7 Test #461: tensornet_GHZSampleTester.checkBroadcastRepeatability .........   Passed    1.57 sec
    Start 559: tensornet_mps_GHZSampleTester.checkBroadcastRepeatability
6/7 Test #559: tensornet_mps_GHZSampleTester.checkBroadcastRepeatability .....   Passed    2.04 sec

@1tnguyen
Support measurement sampling seed for cutensornet backends
403b656 
This feature has been added in 24.08 (cutensornet 2.5), hence adding the
support for it and re-enable the skipped test.

Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Fix a code comment
325f9aa 
Signed-off-by: Thien Nguyen <[email protected]>
sacpis
sacpis approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor changes. Thanks @1tnguyen.

@1tnguyen 1tnguyen requested a review from sacpis November 20, 2024 22:35
sacpis
sacpis approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @1tnguyen.

@1tnguyen
Code format
4944cb5 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen 1tnguyen merged commit d133531 into NVIDIA:main Nov 27, 2024
211 of 212 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@sacpis sacpis sacpis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for random seed in tensornet and tensornet-mps backends
3 participants
@1tnguyen @sacpis @schweitzpgi