Enhance DataWriter to save memory during kudo serialization. #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Renjie Liu <[email protected]>
Signed-off-by: liurenjie1024 <[email protected]>
|
build |
revans2
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
The changes look fine. I think that there are probably simpler ways to do this, but with the current code where we need to maintain compatibility with the JCUDF Serialization for the time being I think this is okay. It would be nice to have a follow on issue to come back and clean things up when we drop support for jcudf serialization.
Sorry, could you be more specific on this? I'm not sure which part should be clean up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2890
reservemethod in DataWriter so that kudo data writer could reserve memory before actual writing happens. This helps avoiding unnecessay allocation and copy.OpenByteArrayOutputStreamand its corresponding data writer.OpenByteArrayOutputStreamcould be used in customized shuffle manager to save memory.ByteArrayOutputStreamWriterwhich helps saving memory copy without introducing any changes to shuffle manager.