Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Qual tool gives inaccurate speedup score of 1.0 when there are failed stages #1551

Open
kuhushukla opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kuhushukla
Copy link
Collaborator

Describe the bug
For a given query run, take 2 eventlogs where one had stage failures (eg. fetch failures) and run the qual tool on it. The eventlog with failed stages will give a score of 1.0 while the other will give a legitimate score. This is an understood limitation(works as intended) of the tools model since we don't want to include stage failure related information to murk the data points for different features. However, with large enterprise customers, we get a very large number of eventlogs with some or the other failure (a lot of times outside the app dev team's full control) and we should try and handle this case better.

Steps/Code to reproduce bug
Note above

Expected behavior
Attempt to give a valid score

Environment details (please complete the following information)

  • Any but in this particular case - YARN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants