Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FragmentedNuclei Bug #352

Open
ryanmrichard opened this issue Jun 27, 2023 · 0 comments
Open

FragmentedNuclei Bug #352

ryanmrichard opened this issue Jun 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ryanmrichard
Copy link
Member

Based on an error I saw elsewhere, I am speculating that if the nuclei in the Nuclei object are identical (including coordinates) you can get FragmentedNuclei which are different to incorrectly compare equal. While one can argue about the physical meaningfulness of stacking atoms literally on top of each other, but it isn't the place of FragmentedNuclei to make that call. If FragmentedNuclei can distinguish among those atoms (which it can because it refers to them by index) then the instances should compare different.

@ryanmrichard ryanmrichard added the bug Something isn't working label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant