Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count_peaks bug #4

Open
igordot opened this issue Jan 24, 2017 · 0 comments
Open

count_peaks bug #4

igordot opened this issue Jan 24, 2017 · 0 comments
Assignees
Labels

Comments

@igordot
Copy link
Member

igordot commented Jan 24, 2017

There is a problem with the count_peaks step that you added. At the beginning, you are reading the input variables:
source ./code/code.main/scripts-read-job-vars $branch "$objects" "genome genome_dir"

But then you are just scanning the directory manually, so you are ignoring them.

Simple example where this makes a difference:
All the peak counts are currently reported, including inputs, which doesn’t really make sense. Inputs should be ignored. It looks like you used the chipseq-diffbind step as an example (there is still chipseq-diffbind code in there). If you check the chipseq-diffbind step, it ignores the inputs.

I think the relevant part is the foreach obj ($objects) loop.

@stevekm stevekm self-assigned this Jan 24, 2017
@stevekm stevekm added the bug label Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants