Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Extracting the API changes from #524 #530

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

deargle
Copy link
Collaborator

@deargle deargle commented Oct 1, 2021

First pass at extracting just the API changes from #524

First pass at extracting just the API changes from #524
@coveralls
Copy link

coveralls commented Oct 1, 2021

Coverage Status

Coverage decreased (-1.5%) to 58.68% when pulling 0bc175a on api-add-resources into 2c0b901 on master.

@deargle
Copy link
Collaborator Author

deargle commented Oct 1, 2021

#524 had a lot of changes to the api route functionality that I don't want to merge. But I do want its WorkerList resource, and its download-datafiles helper routes. Might change them a bit, but this is a first pass at extracting the relevant changes from that PR.

@deargle deargle changed the title Extracting the API changes from #524 WIP: Extracting the API changes from #524 Oct 5, 2021
WorkerList shouldn't accept a list of worker ids to filter on -- create 
a separate resource Worker to get a single worker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants