Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a template version of the latex parser that doesn't use wchar_t #82

Open
appetrosyan opened this issue Jun 3, 2021 · 2 comments
Open

Comments

@appetrosyan
Copy link

Hi. Most LaTeX is not possible to use as UTF-16, so the wchar_t support seems mostly to be needed for the internationalisation support, and not LaTeX.

As it stands, it may be worth exploring a code path that doesn't rely on wchar_t and instead directly uses UTF-8 strings. In my case, this would significantly reduce the memory footprint, (embedded systems need to be miserly with the RAM), so I was wondering if you'd accept a PR that did that?

@NanoMichael
Copy link
Owner

so I was wondering if you'd accept a PR that did that?

Yes, your PR is very welcome. I'm planning to replace the std::wstring with the plain old UTF-8 strings. Because the parser needs to iterate over the string to get the Unicode codepoint of the character, I've followed the most intuitive and easy way 😅 .

@NanoMichael
Copy link
Owner

There's no wchar_t anymore, please take a look at the branch openmath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants