feat(build): migrate to esm from cjs BREAKING_CHANGE #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorinevo
force-pushed
the
feat/migrate-to-esm
branch
from
2577465 to
3fe66ce
Compare
aorinevo
changed the title
aorinevo
changed the title
aorinevo
force-pushed
the
feat/migrate-to-esm
branch
from
3fe66ce to
af581f1
Compare
|
Not sure why, but the linting step, while successful, ultimately gets canceled (see screenshot). 
|
kavitha186
approved these changes
Feb 4, 2024
aorinevo
force-pushed
the
feat/migrate-to-esm
branch
3 times, most recently
from
0e769d7 to
8e816b1
Compare
aorinevo
force-pushed
the
feat/migrate-to-esm
branch
from
8e816b1 to
2d187fd
Compare
|
Issue is likely due to the fact that node.matrix contained Node v22 which hasn't been released yet. |
|
Close in favor of #846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
BREAKING_CHANGE: This PR migrates Shepherd codebase to ESM from CJS.
Benefits
Highlights
.jsis added. Note, using.tsextension is an option but in compiling the code, the import paths are not updated to.jswhich is an issue.__dirnameand__filenamevariables are available in CommonJS but not ESM environments and requires a bit more work to get these values. See, for example: https://github.com/NerdWalletOSS/shepherd/pull/690/files#diff-f89d0ffd37a33ca099d3286296b3159bd3c8faa06c9f22fd88733902bf89b437R6-R7Todo
.jsextension vs.ts.Local Test Screenshots