Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric other than sample count #23

Closed
ceeaspb opened this issue Apr 8, 2018 · 2 comments
Closed

metric other than sample count #23

ceeaspb opened this issue Apr 8, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@ceeaspb
Copy link
Contributor

ceeaspb commented Apr 8, 2018

Thanks, great tool.

It would be interesting to have the heat map present other metrics than cpu sample count.

For example throughput and especially some latency statistic (eg median, 99th etc).

The data would come from elsewhere so would need to follow some predefined format, at the right interval.

Expect It likely not be possible to collect this kind of data from production systems. Test/ Benchmark systems may be able to though.

It might be a problem to marry up the perf kernel timestamps to userspace timestamps. it might fall on the perf record end to get the right clock.

$ perf record -h 2>&1|grep -i clock
    -k, --clockid <clockid>
                          clockid to use for events, see clock_gettime()```

@spiermar spiermar added enhancement New feature or request review Tagged for review. labels Apr 9, 2018
@spiermar
Copy link
Contributor

spiermar commented Apr 9, 2018

Thanks for the suggestion @ceeaspb ! We already did it with a few other metrics internally and might be able to share something in the future.
In cases like that, what worked for us is adding a tools directory in the repo, with scripts to collect the data and format it in a way FlameScope can understand. If you have something specific in mind, we're open to PRs.

@spiermar spiermar removed the review Tagged for review. label Feb 27, 2019
@spiermar
Copy link
Contributor

New profile formats should resolve this issue. See #69 for details. Closing to centralize discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants