Boundary for SpatialSeries #567
Conversation
|
Fix #524 |
|
Review Notes: For the dtype my assumption was to use float32 (per the original issue poster's notes). When I think of a boundary, I imagined this: |
|
Pinging @mavaylon1 about comments above. |
FYI @mavaylon1 GitHub will only automatically close this issue if the "fix X" syntax is used in the PR description, not a comment, so I recommend that you edit the first post to include that. (Example where the PR comment did not close the issue) |
|
2.7.0 has been released, so this will have to move to 2.8.0. Please adjust the version strings appropriately as described in the checklist in the first post. |
Co-authored-by: Ryan Ly <[email protected]>
2.7.0 has not been released |
I released it last month while you were away https://github.com/NeurodataWithoutBorders/nwb-schema/releases/tag/2.7.0 to try to get a pynwb release that includes support for it, but I did not manage to get the pynwb side done in time before my vacation. So PyNWB and MatNWB are due for a release that adds 2.7.0 support. |
Co-authored-by: Ryan Ly <[email protected]>
|
Can you revert the hdmf-common-schema update for reasons mentioned here: hdmf-dev/hdmf-common-schema#80 (comment) ? |
Done. I also added this to the PR checklist. |
|
Looks good. Thanks! Out of an abundance of caution, let's not merge this until we implement and test support for this change in a branch/PR of PyNWB. Can you do that @mavaylon1 ? |
Will do. |
|
@rly I made a test for this but it's getting weird on pynwb where we are on a branch built from your branch for schema 2.7 in pynwb branch that has nwb-schema pointing to a branch. Let's merge this. Especially since our new policy is to point our schemas to the latest release and not the main/dev of the schema repo, meaning this won't mess with pynwb. |
Summary of changes
Optional attribute,
bounds, for SpatialSeries data.Fix #524
Checklist
For all schema changes:
docs/format/source/format_release_notes.rst.If this is the first schema change after a schema release (i.e., the version string in
core/nwb.namespace.yamldoes notend in "-alpha"), then:
core/nwb.namespace.yamlandcore/nwb.file.yamlto the next major/minor/patchversion with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
new version string should be "2.5.0-alpha".
versionvariable indocs/format/source/conf.pyto the next version without thesuffix "-alpha", e.g., "2.5.0".
releasevariable indocs/format/source/conf.pyto the next version with the suffix"-alpha", e.g., "2.5.0-alpha".
docs/format/source/format_release_notes.rstfor the new versionwith the date "Upcoming" in parentheses.