Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add num samples to ImageSeries when external mode is used #561

Open
3 tasks done
h-mayorquin opened this issue Dec 12, 2023 · 2 comments
Open
3 tasks done
Labels
category: enhancement improvements of code or code behavior
Milestone

Comments

@h-mayorquin
Copy link
Contributor

What would you like to see added to PyNWB?

@bendichter
Here is the time alignment view of Neurosift from an nwbfile that contains an ImageSeries with external video:

image

It should be noticeable that the information of time duration is missing for the ImageSeries. The reason is that the length can be estimated when there are timestamps or when there is a staring_time, rate and crucially num_samples (data.shape[0]). But here, the later is missing.

It would be great to have this added to the schema. Note that the starting_frame is not enough to determine the number of frames available for a single ImageSeries in external mode.

Weakly related to this other issue where some guidelines were given:
NeurodataWithoutBorders/pynwb#1433

Is your feature request related to a problem?

No response

What solution would you like?

Adding num_samples in the schema for this object or modify the data attribute in the case of external series so shape[0] reflects the number of samples.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@oruebel oruebel transferred this issue from NeurodataWithoutBorders/pynwb Dec 12, 2023
@oruebel oruebel added the category: enhancement improvements of code or code behavior label Dec 12, 2023
@oruebel
Copy link
Contributor

oruebel commented Dec 12, 2023

I transferred the issue to the schema repo since this issue is about making changes to the schema

@h-mayorquin
Copy link
Contributor Author

#543 same probably

@rly rly added this to the 2.8.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Development

No branches or pull requests

3 participants