Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance-profile, update user data #26

Open
noamgreen opened this issue Aug 6, 2024 · 8 comments
Open

Instance-profile, update user data #26

noamgreen opened this issue Aug 6, 2024 · 8 comments

Comments

@noamgreen
Copy link

HI , can you add support to "Instance-profile" and manual enter the user data or just give the option to not "runner_no_update"

github is auto update the runner ver at start , there is not way to add "--disableupdate" in the user data section

Thanks in advance

Noam

@mahdi-torabi
Copy link
Contributor

Would an option to pass raw CLI args to the runner startup command via a space delimited string be okay ? e.g "--sometime value --somethingElse value2"

@mahdi-torabi
Copy link
Contributor

I am testing this as a quick solution #27

I'll look into instance-profiles and custom user data after this.

@noamgreen
Copy link
Author

HI , look like this part is working i add the "github_action_runner_extra_cli_args" i can conform its working
Many thanks

@mahdi-torabi
Copy link
Contributor

I'll merge it to main and draft a release later this evening.

I'd like to keep this issue open for the Instance-profile work

@noamgreen
Copy link
Author

noamgreen commented Aug 6, 2024

for the instance profile i think this will help
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/ec2/command/AssociateIamInstanceProfileCommand/

the instance-profile must be created in advance and have IAM police attached
if you need me to add some links about the CLI commands let me know i will help

@noamgreen
Copy link
Author

@mahdi-torabi Hi, did you find a way to add instance-profile

@vnetmx
Copy link
Contributor

vnetmx commented Aug 30, 2024

@noamgreen I'm working on the InstanceProfile option as I need it for a project,

#29

@mahdi-torabi
Copy link
Contributor

Merged. I'll verify and create a release this evening. There's a couple of other changes that I'd like to get out along with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants