Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move off reach-ui #165

Closed
NickyMeuleman opened this issue Oct 20, 2022 · 3 comments
Closed

Move off reach-ui #165

NickyMeuleman opened this issue Oct 20, 2022 · 3 comments

Comments

@NickyMeuleman
Copy link
Owner

NickyMeuleman commented Oct 20, 2022 •
edited
Loading

reach/reach-ui#972

Specifically @reach/tabs and @reach/tooltip

Edit: I want to make clear @chaance is awesome.
(And he's the reason for my blogposts have that <details> element to the side btw, still love that)
@NickyMeuleman
Copy link
Owner Author

alternative: do nothing and wait until @reach/tabs is React 18 compatible
reach/reach-ui#972 (comment)

@chaance
Copy link

chaance commented Oct 20, 2022

FWIW I do think I'm close on getting descendants working for React 18, which is the only holdup for Tabs. Tooltip is probably fine, but we do some DOM manipulation in effects that concerns me considering StrictMode will run those effects twice. I think those are also probably fine, they just need a good review when I have time.

@NickyMeuleman
Copy link
Owner Author

closing all issues before complete rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaance @NickyMeuleman