Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exfat-nofuse building failure for linux 5 #57063

Closed
SchrodingerZhu opened this issue Mar 8, 2019 · 5 comments
Closed

exfat-nofuse building failure for linux 5 #57063

SchrodingerZhu opened this issue Mar 8, 2019 · 5 comments

Comments

@SchrodingerZhu
Copy link

There is a patch for linux 5 in the repo of exfat-nofuse. Consider patch it.

@SchrodingerZhu
Copy link
Author

@rycee
Copy link
Member

rycee commented Sep 1, 2019

Adding

diff --git a/pkgs/os-specific/linux/exfat/default.nix b/pkgs/os-specific/linux/exfat/default.nix
index 036cd3f28a1..64c0560ba80 100644
--- a/pkgs/os-specific/linux/exfat/default.nix
+++ b/pkgs/os-specific/linux/exfat/default.nix
@@ -28,6 +28,12 @@ stdenv.mkDerivation rec {
   '';
 
   patches = [
+    # Fix compilation error on Linux 5.
+    (fetchpatch {
+      url = https://github.com/barrybingo/exfat-nofuse/commit/8b59e1f338fdd87f1d5a9db2a119a3745bb467d5.patch;
+      sha256 = "1ldra9zn45wk8xlr688csjr9z4m2zkfllaf47p6issmz875s1wca";
+    })
+
     # fix compile-errors in 4.18 and 4.20
     # ref: https://github.com/dorimanx/exfat-nofuse/pull/137
     (fetchpatch {

might work.

Edit: Tried a build with this patch and it didn't seem to work completely, the patch is probably adjusted for the barrybingo repo.

CC: @makefu

@bricewge
Copy link
Contributor

PR #68647 should fix this.

@rycee
Copy link
Member

rycee commented Sep 22, 2019

Neat. Btw. I retried the patch I gave above and now everything worked fine and I'm able to mount an exfat sd card on a system running Linux 5.2.16.

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

This package has been updated now in #68647

@Mic92 Mic92 closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants