gcviewer: init at 1.37-unreleased #276100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.36 was released 4 years ago so we opt for a more recent, unreleased version.
ofborg
bot
added
11.by: package-maintainer
Is upstream alive? Have you tried contacting them about making a new release? |
It has had commits in the last year, so it's not "dead". I opened an issue to request a new release: chewiebug/GCViewer#276 |
wegank
added
the
2.status: stale
FliegendeWurst
requested changes
Nov 17, 2024
| in | ||
| maven.buildMavenPackage { | ||
| pname = "GCViewer"; | ||
| version = "1.37-unreleased"; |
There was a problem hiding this comment.
Suggested change
| version = "1.37-unreleased"; | |
| version = "1.37-unstable-YYYY-MM-DD"; |
with the date of last commit.
|
|
||
| nativeBuildInputs = [ git makeWrapper ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Should include runHook preInstall, runHook postInstall
| mkdir -p $out/bin $out/share | ||
| jarfile=$(cd target && echo *.jar) | ||
| install -Dm644 "target/$jarfile" $out/share/ | ||
| makeWrapper ${jre}/bin/java $out/bin/gcviewer \ |
There was a problem hiding this comment.
Suggested change
| makeWrapper ${jre}/bin/java $out/bin/gcviewer \ | |
| makeWrapper ${lib.getExe jre} $out/bin/gcviewer \ |
| rev = "af97692884ac918ccbdf7a123fa698460a1d397e"; | ||
| hash = "sha256-o4TPerkcu1Um701IHqqRQr/eCjm+WUCbI0uZBlhCBis="; | ||
| } | ||
| ; |
There was a problem hiding this comment.
Please format with the new formatter.
stale
bot
removed
2.status: stale
FliegendeWurst
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Version 1.36 was released 4 years ago so we opt for a more recent, unreleased version.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.