Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap sampling #336

Open
Grogu1992 opened this issue Feb 25, 2025 · 1 comment · May be fixed by #337
Open

bootstrap sampling #336

Grogu1992 opened this issue Feb 25, 2025 · 1 comment · May be fixed by #337

Comments

@Grogu1992
Copy link

I am applying "probabilistic reconciliation" using the bootstrap intervals_method. I have been trying to replicate the method’s results for different sample sizes; however, I only get exactly the same results when the sample size is set to 200.

I reviewed the code for the reconcile method and noticed that a default value of 200 is assigned to the reconciler's arguments.

Is this correct? If so, is there any explanation for it?
Is there any way to change this parameter using the input arguments of the reconcile method?

Thanks

@Grogu1992 Grogu1992 changed the title bootstraping sampling bootstrap sampling Feb 25, 2025
@elephaint
Copy link
Contributor

elephaint commented Feb 26, 2025

I am applying "probabilistic reconciliation" using the bootstrap intervals_method. I have been trying to replicate the method’s results for different sample sizes; however, I only get exactly the same results when the sample size is set to 200.

Do you have code that I can run that shows the difference?

I reviewed the code for the reconcile method and noticed that a default value of 200 is assigned to the reconciler's arguments.

Is this correct? If so, is there any explanation for it? Is there any way to change this parameter using the input arguments of the reconcile method?

Thanks

It's correct; it's because it can be the case that num_samples isn't provided but level is, and then we need n_samples to be positive. However, that can be more easily achieved I think, so I think we will change this behavior.

No, atm you can't change that parameter.

@elephaint elephaint linked a pull request Feb 26, 2025 that will close this issue
@elephaint elephaint linked a pull request Feb 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants