Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better model and deserialize the Solidity compiler output used to decode stack traces #636

Open
Xanewok opened this issue Aug 30, 2024 · 0 comments

Comments

@Xanewok
Copy link
Contributor

Xanewok commented Aug 30, 2024

In #545 we migrated 1:1 the logic from Hardhat (TypeScript) to deserialize the Solidity compiler standard JSON input/output and convert this into a "build model" that's used to decode the stack traces.

The original code was translated quite literally, so there's a lot of serde_json::Value usage and manipulation. We should model the deserialization for the input/output more declaratively rather than accepting a JSON blob and doing the conversion ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant