Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve combinator rewrites during parsing #1153

Open
OmarTawfik opened this issue Nov 19, 2024 · 0 comments
Open

improve combinator rewrites during parsing #1153

OmarTawfik opened this issue Nov 19, 2024 · 0 comments

Comments

@OmarTawfik
Copy link
Collaborator

OmarTawfik commented Nov 19, 2024

The combinators we use in parsing propagate results through types like ParseResult. These results often get rewritten/copied in every call.

TODO: investigate the perf impact of these, and if we need to improve that data structure. For example, now that labels are required everywhere, we can always create complete edges, without needing to rewrite results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant