Refactor RestoreCommand.ExecuteAsync() #6162
Open
+328
−242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think your rebase removed 0029325, which is why your tests are failing. |
nkolev92
reviewed
Nov 26, 2024
nkolev92
reviewed
Nov 26, 2024
| } | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
When is the cache file null?
Feels like it shouldn't be.
Worth double checking.
There was a problem hiding this comment.
The return null was added to ensure the method covers all possible code paths with a return statement. I modified the ExecuteAsync method to handle scenarios where this method returns null, allowing such cases to be ignored.
Previous ExecuteAsync
{
// EvaluateNoOpAsync method logic
}Updated ExecuteAsync
{
if (EvaluateNoOpAsync() is null)
{
continue;
}
else
{
return noOpResult;
}
}EvaluateNoOpAsync
EvaluateNoOpAsync()
{
// Same logic
// Ensure all paths return
return null;
}
jeffkl
requested changes
Nov 26, 2024
jeffkl
reviewed
Nov 26, 2024
jgonz120
approved these changes
Nov 27, 2024
| private async Task<IEnumerable<RestoreTargetGraph>> GenerateRestoreGraphsAsync(TelemetryActivity telemetry, RemoteWalkContext contextForProject, CancellationToken token) | ||
| { | ||
| IEnumerable<RestoreTargetGraph> graphs = null; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13960
Description
The
RestoreCommand.ExecuteAsync()method is long and complicated to read. This PR refactors it into multiple methods.PR Checklist