-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] account_analytic_organization: Added company_id field and fixed spanish translation #697
base: 16.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as expected in runboat and code review
da75895
to
f75b62b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
Hi @pedrobaeza! Is this ready to merge? |
Being your module, it's advisable that any of you put it as maintainer of the module, and then you will be independent to merge these fixes without depending of someone like me. Please do it and I'll merge, and from now on, you will fly alone, hehe. |
…xed spanish translation and made organization name appear in partner name
f75b62b
to
70213d3
Compare
Done! Thanks for your help :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
On this improvement i added the company_id field to make it work better with multi-company option and fixed spanish translation. I also inherited get_name method in order to show the organization name in the partner name.
cc https://github.com/APSL 160524
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @BernatObrador @ppyczko please review