Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 13.0 #290

Closed
2 of 13 tasks
OCA-git-bot opened this issue Sep 29, 2019 · 12 comments
Closed
2 of 13 tasks

Migration to version 13.0 #290

OCA-git-bot opened this issue Sep 29, 2019 · 12 comments
Labels
help wanted stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress
Milestone

Comments

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 29, 2019

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

@yvaucher
Copy link
Member

@OCA/accounting-maintainers In l10n-switzerland we will get rid of the dependency on module base_transaction_id. I suggest to not migrate this module to version 13.0. Any objection, was it used elsewhere?

@pedrobaeza
Copy link
Member

I think it's used in some reconcile modules by your company.

@florian-dacosta
Copy link
Contributor

@yvaucher https://github.com/OCA/account-reconcile/tree/10.0/account_mass_reconcile_transaction_ref
I think it is still relevant, no?
I actually use this module for a customer (v9)

@yvaucher
Copy link
Member

yvaucher commented Dec 2, 2019

Question is: Will you be using it in version 13.0 or later. In version 9.0 we were lacking a proper field to save a payment reference for reconciliation. But, since version 12.0 I see no reasons to not use the standard reference field.

@florian-dacosta
Copy link
Contributor

I am not sure to know which field exactly you are talking about.
I did not need to install all the reconciliation stuff in version 12 yet, so I am not sure, but I am not aware of a better field for this use.
So AFAIK I would still need it, but I may be wrong.

@kittiu
Copy link
Member

kittiu commented Jan 6, 2020

Working on account_move_reconcile_helper
#301

@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Jan 29, 2020

bank_statement_foreign_currency is deprecated (or merged into account), because the fields in the view have the optional="hidden"

@MiquelRForgeFlow
Copy link
Contributor

account_partner_reconcile #303

@phuctranfxvn
Copy link

account_reconcile_rule done here #354

@phuctranfxvn
Copy link

account_reconcile_rule_early_payment_discount migrated here #356

@yvaucher
Copy link
Member

yvaucher commented Nov 10, 2020

@florian-dacosta as I worked on this again lately for base_transaction_id, you don't need base_transaction_id in version 13.0. The field invoice_payment_ref is there for that. https://github.com/odoo/odoo/blob/13.0/addons/account/models/account_move.py#L202

You can see it is used in the reconcile matching query:
https://github.com/odoo/odoo/blob/13.0/addons/account/models/account_reconcile_model.py#L602

Note: this is different in v12

@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress
Projects
None yet
Development

No branches or pull requests

7 participants