Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] ddmrp: add RFQ qty info inside of the DLT Horizon and RFQ total Qty #494

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[16.0][IMP] ddmrp: add RFQ qty info inside of the DLT Horizon and RFQ total Qty #494

merged 3 commits into from
Nov 25, 2024

Conversation

AlexPForgeFlow
Copy link
Contributor

Add RFQ qty info inside of the DLT Horizon.

cc. @LoisRForgeFlow @JordiBForgeFlow

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow, @ChrisOForgeFlow, @JordiBForgeFlow,
some modules you are maintaining are being modified, check this out!

LoisRForgeFlow
LoisRForgeFlow reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include the state "to approve" in the method _get_rfq_dlt?

Also, could you take the ocassion to evaluate if we can unify logic and use _get_rfq_dlt in _quantity_in_progress method?

Another comment inline below.

ddmrp/views/stock_buffer_view.xml Outdated Show resolved Hide resolved
ddmrp/views/stock_buffer_view.xml Outdated Show resolved Hide resolved
@AlexPForgeFlow AlexPForgeFlow force-pushed the 16.0-add-rfq_inside_dlt_qty branch from aad3671 to cb80faf Compare November 4, 2024 15:02
@AlexPForgeFlow AlexPForgeFlow force-pushed the 16.0-add-rfq_inside_dlt_qty branch from ea5498b to 7ea6e4f Compare November 4, 2024 16:29
@AlexPForgeFlow AlexPForgeFlow force-pushed the 16.0-add-rfq_inside_dlt_qty branch from 7ea6e4f to b747a1b Compare November 5, 2024 10:31
@AlexPForgeFlow AlexPForgeFlow force-pushed the 16.0-add-rfq_inside_dlt_qty branch from 0a2969c to 2a3f8e3 Compare November 18, 2024 14:36
@AlexPForgeFlow AlexPForgeFlow changed the title [16.0][IMP] ddmrp: add RFQ qty info inside of the DLT Horizon [16.0][IMP] ddmrp: add RFQ qty info inside of the DLT Horizon and RFQ total Qty Nov 21, 2024
LoisRForgeFlow
LoisRForgeFlow approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-494-by-LoisRForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f8b2eb4. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 8c03cd9 into OCA:16.0 Nov 25, 2024
7 checks passed
@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-add-rfq_inside_dlt_qty branch November 25, 2024 12:08
@LoisRForgeFlow
Copy link
Contributor

@AlexPForgeFlow can you port this to 15.0 and 17.0? Thanks!

This was referenced Nov 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexPForgeFlow @OCA-git-bot @LoisRForgeFlow