[16.0][MIG] website_sale_suggest_create_account: Migration to version 16.0 #836
Conversation
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_suggest_create_account
branch
5 times, most recently
from
e0bedb6 to
de55c3a
Compare
|
/ocabot migration website_sale_suggest_create_account |
|
Runboat is not working from yesterday. GH is returning 422 error to the runboat service, as @sbidoul commented yesterday, but now there's no bad status on hooks according status page. |
|
Oh, thanks. I'll test locally then |
There was a problem hiding this comment.
I'd simplify it. To me, it makes more sense this behavior:
Sign in/up checkout:
- optional -> Sign in/up and checkout
- disabled -> Sign in and checkout button
- mandatory -> Sign in/up and checkout (the same one that in the first place)
Indeed you just need to change the button text
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_suggest_create_account
branch
from
de55c3a to
6d49b50
Compare
I have made the change in the button names but in the "mandatory" option it is not allowed to checkout without being registered/logged in, by default the login button appears and I have also added the registration button. In short, the three options are:
|
Then just change the original text to Sign in/up. The place for the user to decide whether to create a new account or to log in with an existing one is /web/login |
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_suggest_create_account
branch
from
6d49b50 to
f70de7d
Compare
The changes are already made to both the button name/link and the template, so it would appear in the "Mandatory" option: |
There was a problem hiding this comment.
By making these changes we are adding the functionality of the https://github.com/OCA/e-commerce/tree/15.0/website_sale_require_login module to this one, right?
If so, please add the necessary migration scripts.
website_sale_require_login has been merged into website_sale, here is the migration script: |
|
Thx 😄 |
|
@pedrobaeza Can this be merged? |
|
You should squash administrative commits and the translations commits from the same author (not mixing languages). |
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_suggest_create_account
branch
from
f70de7d to
7f360cf
Compare
done, thanks :) |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
But now the error is in the tests, the same one that comes and goes as it pleases. I investigate and replicate locally to see what I can find out. |
|
It only fails persistently in Odoo one (not OCB). You locally have OCB. Please check with Odoo latest source code to see. |
Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout
Always show 'Process Checkout', not highlighted if user not logged in Suggest to login or signup, according to 'invitation_scope', avoiding too many buttons in cart page
Currently translated at 100.0% (4 of 4 strings) Translation: e-commerce-12.0/e-commerce-12.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_suggest_create_account/es/
Ensure that 'vat' is not empty for compatibility with website_sale_vat_required module
…with `Environment.manage()`
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_suggest_create_account
branch
from
02393c2 to
e6a75bc
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b20069b. Thanks a lot for contributing to OCA. ❤️ |
This PR supersedes #705
cc @Tecnativa TT44387
@chienandalu @CarlosRoca13 please review :)