[MIG] project_task_code: Migration to 16.0

Author: kg-ucs

project_task_code/README.rst

@@ -14,14 +14,14 @@ Sequential Code for Tasks
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproject-lightgray.png?logo=github
-    :target: https://github.com/OCA/project/tree/15.0/project_task_code
+    :target: https://github.com/OCA/project/tree/16.0/project_task_code
     :alt: OCA/project
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_task_code
+    :target: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code
     :alt: Translate me on Weblate
-.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
-    :target: https://runbot.odoo-community.org/runbot/140/15.0
-    :alt: Try me on Runbot
+.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
+    :target: https://runboat.odoo-community.org/webui/builds.html?repo=OCA/project&target_branch=16.0
+    :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5| 
 
@@ -41,6 +41,12 @@ To change the task code sequence, you must:
 #. Go to Settings > Technical > Sequences & Identifiers > Sequences.
 #. Click on "Task code" sequence to edit.
 
+To activate the task code sequence unique constraint, you must:
+
+#. Activate the developer mode.
+#. Go to Project > Configuration > Settings.
+#. Check the "Unique Task Code" check box and save.
+
 Usage
 =====
 
@@ -56,7 +62,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/project/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/project/issues/new?body=module:%20project_task_code%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/project/issues/new?body=module:%20project_task_code%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -86,6 +92,7 @@ Contributors
 * Saran Lim. <[email protected]>
 * Tharathip Chaweewongphan <[email protected]>
 * Ruchir Shukla <[email protected]>
+* Abraham Anes <[email protected]>
 
 Maintainers
 ~~~~~~~~~~~
@@ -100,6 +107,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/project <https://github.com/OCA/project/tree/15.0/project_task_code>`_ project on GitHub.
+This module is part of the `OCA/project <https://github.com/OCA/project/tree/16.0/project_task_code>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

project_task_code/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "Sequential Code for Tasks",
-    "version": "15.0.1.0.4",
+    "version": "16.0.1.0.0",
     "category": "Project Management",
     "author": "OdooMRP team, "
     "AvanzOSC, "
@@ -17,6 +17,7 @@
     "data": [
         "data/task_sequence.xml",
         "views/project_view.xml",
+        "views/res_config_settings_view.xml",
     ],
     "installable": True,
     "pre_init_hook": "pre_init_hook",

project_task_code/models/__init__.py

@@ -1,3 +1,4 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from . import project_task
+from . import res_config_settings

project_task_code/models/project_task.py

@@ -2,6 +2,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from odoo import _, api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class ProjectTask(models.Model):
@@ -15,23 +16,29 @@ class ProjectTask(models.Model):
         copy=False,
     )
 
-    _sql_constraints = [
-        ("project_task_unique_code", "UNIQUE (code)", _("The code must be unique!")),
-    ]
+    @api.constrains("code")
+    def _check_project_task_unique_code(self):
+        project_task_unique_code = (
+            self.env["ir.config_parameter"]
+            .sudo()
+            .get_param("project_task_code.project_task_unique_code")
+        )
+
+        if not project_task_unique_code:
+            return
+
+        for task in self:
+            if self.search([("code", "=", task.code), ("id", "!=", task.id)], limit=1):
+                raise ValidationError(_("The code must be unique!"))
 
     @api.model_create_multi
     def create(self, vals_list):
-        new_list = []
         for vals in vals_list:
             if vals.get("code", "/") == "/":
-                new_vals = dict(
-                    vals,
-                    code=self.env["ir.sequence"].next_by_code("project.task") or "/",
+                vals["code"] = (
+                    self.env["ir.sequence"].next_by_code("project.task") or "/"
                 )
-            else:
-                new_vals = vals
-            new_list.append(new_vals)
-        return super().create(new_list)
+        return super().create(vals_list)
 
     def name_get(self):
         result = super().name_get()

project_task_code/models/res_config_settings.py

@@ -0,0 +1,14 @@
+# Copyright 2023 Abraham Anes <[email protected]>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import fields, models
+
+
+class ResConfigSettings(models.TransientModel):
+    _inherit = "res.config.settings"
+
+    project_task_unique_code = fields.Boolean(
+        string="Unique Task Code",
+        config_parameter="project_task_code.project_task_unique_code",
+        default=False,
+    )

project_task_code/readme/CONFIGURE.rst

@@ -3,3 +3,9 @@ To change the task code sequence, you must:
 #. Activate the developer mode.
 #. Go to Settings > Technical > Sequences & Identifiers > Sequences.
 #. Click on "Task code" sequence to edit.
+
+To activate the task code sequence unique constraint, you must:
+
+#. Activate the developer mode.
+#. Go to Project > Configuration > Settings.
+#. Check the "Unique Task Code" check box and save.

project_task_code/readme/CONTRIBUTORS.rst

@@ -11,3 +11,4 @@
 * Saran Lim. <[email protected]>
 * Tharathip Chaweewongphan <[email protected]>
 * Ruchir Shukla <[email protected]>
+* Abraham Anes <[email protected]>

project_task_code/static/description/index.html

@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
 <title>Sequential Code for Tasks</title>
 <style type="text/css">
 
@@ -367,7 +367,7 @@ <h1 class="title">Sequential Code for Tasks</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/project/tree/15.0/project_task_code"><img alt="OCA/project" src="https://img.shields.io/badge/github-OCA%2Fproject-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_task_code"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/140/15.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/project/tree/16.0/project_task_code"><img alt="OCA/project" src="https://img.shields.io/badge/github-OCA%2Fproject-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runboat.odoo-community.org/webui/builds.html?repo=OCA/project&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds a sequential code for tasks.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -391,6 +391,12 @@ <h1><a class="toc-backref" href="#id1">Configuration</a></h1>
 <li>Go to Settings &gt; Technical &gt; Sequences &amp; Identifiers &gt; Sequences.</li>
 <li>Click on “Task code” sequence to edit.</li>
 </ol>
+<p>To activate the task code sequence unique constraint, you must:</p>
+<ol class="arabic simple">
+<li>Activate the developer mode.</li>
+<li>Go to Project &gt; Configuration &gt; Settings.</li>
+<li>Check the “Unique Task Code” check box and save.</li>
+</ol>
 </div>
 <div class="section" id="usage">
 <h1><a class="toc-backref" href="#id2">Usage</a></h1>
@@ -404,7 +410,7 @@ <h1><a class="toc-backref" href="#id3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/project/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/project/issues/new?body=module:%20project_task_code%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/project/issues/new?body=module:%20project_task_code%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -433,6 +439,7 @@ <h2><a class="toc-backref" href="#id6">Contributors</a></h2>
 <li>Saran Lim. &lt;<a class="reference external" href="mailto:saranl&#64;ecosoft.co.th">saranl&#64;ecosoft.co.th</a>&gt;</li>
 <li>Tharathip Chaweewongphan &lt;<a class="reference external" href="mailto:tharathipc&#64;ecosoft.co.th">tharathipc&#64;ecosoft.co.th</a>&gt;</li>
 <li>Ruchir Shukla &lt;<a class="reference external" href="mailto:ruchir&#64;bizzappdev.com">ruchir&#64;bizzappdev.com</a>&gt;</li>
+<li>Abraham Anes &lt;<a class="reference external" href="mailto:abrahamanes&#64;gmail.com">abrahamanes&#64;gmail.com</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -442,7 +449,7 @@ <h2><a class="toc-backref" href="#id7">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/project/tree/15.0/project_task_code">OCA/project</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/project/tree/16.0/project_task_code">OCA/project</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

project_task_code/tests/test_project_task_code.py

@@ -2,6 +2,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 import odoo.tests.common as common
+from odoo.exceptions import ValidationError
 
 
 class TestProjectTaskCode(common.TransactionCase):
@@ -10,7 +11,7 @@ def setUp(self):
         self.project_task_model = self.env["project.task"]
         self.ir_sequence_model = self.env["ir.sequence"]
         self.task_sequence = self.env.ref("project_task_code.sequence_task")
-        self.project_task = self.env.ref("project.project_task_1")
+        self.project_task = self.env.ref("project.project_1_task_1")
 
     def test_old_task_code_assign(self):
         project_tasks = self.project_task_model.search([])
@@ -38,3 +39,15 @@ def test_name_get(self):
         )
         result = project_task.name_get()
         self.assertEqual(result[0][1], "[%s] Task Testing Get Name" % code)
+
+    def test_unique_task_code(self):
+        # Enable unique task code constraint
+        self.env["ir.config_parameter"].sudo().set_param(
+            "project_task_code.project_task_unique_code", True
+        )
+
+        project_task = self.project_task_model.create({"name": "Testing task code"})
+        with self.assertRaises(ValidationError):
+            self.project_task_model.create(
+                {"name": "Testing task code", "code": project_task.code}
+            )

project_task_code/views/res_config_settings_view.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <record id="res_config_settings_view_form_inherit" model="ir.ui.view">
+        <field name="name">res.config.settings.view.form.inherit</field>
+        <field name="model">res.config.settings</field>
+        <field name="inherit_id" ref="project.res_config_settings_view_form" />
+        <field name="arch" type="xml">
+            <xpath expr="//div[@id='tasks_management']" position="inside">
+                <div class="col-12 col-lg-6 o_setting_box" id="project_task_code">
+                    <div class="o_setting_left_pane">
+                        <field name="project_task_unique_code" />
+                    </div>
+                    <div class="o_setting_right_pane">
+                        <label for="project_task_unique_code" />
+                        <div class="text-muted">
+                            Makes the task code have to be unique
+                        </div>
+                    </div>
+                </div>
+            </xpath>
+        </field>
+    </record>
+</odoo>

setup/project_task_code/odoo/addons/project_task_code

@@ -0,0 +1 @@
+../../../../project_task_code

setup/project_task_code/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)