Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] project_sequence: Migration to 18.0 #1370

Merged
merged 26 commits into from
Dec 18, 2024

Conversation

BT-mchechlacz
Copy link

No description provided.

OCA-git-bot and others added 25 commits November 19, 2024 13:15
When a project has a name, still the sequence is a very important field to be displayed. I move it below the project name.

@moduon MT-1506
`hr_timesheet` creates an analytic account by default. The method it uses to create it expects a preexisting name. But since we're making name not required, we're breaking other module's expectations.

To fix this problem, now the name sync is done before writing or creating records, and not after.

To make sure the problem doesn't happen anymore, we keep the `NOT NULL` requirement on project names. We just do it with a manual SQL constraint. This extra protection ensures compatibility with any other modules that expect always a value on the name.

Any possibly misconfigured sequence could produce sequence duplicates. I also add protection against that.

In tests, the project sequence was wrongly reset to 11 only once. Turns out that it survives the test savepoint, so I now reset it before each test instead. Tests are more reliable now. Besides, I added some more.

@moduon MT-1506

wip

wip
These projects shouldn't display "False - Project name" in their display names.

@moduon MT-1506

[UPD] Update project_sequence.pot

[UPD] README.rst

project_sequence 14.0.0.1.1
To change the project display name pattern, follow these steps:

1. Go to *Project > Configuration > Settings*.
2. Edit the *Project display name pattern* field.

   The default format is ``%(sequence_code)s - %(name)s``. You can use those
   same placeholders to customize the pattern.

@moduon MT-1506

[UPD] Update project_sequence.pot

[UPD] README.rst

project_sequence 14.0.0.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-14.0/project-14.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_sequence/
@moduon MT-2822

[UPD] Update project_sequence.pot

[UPD] README.rst

project_sequence 15.0.0.2.1
Translated using Weblate (Italian)

Currently translated at 100.0% (9 of 9 strings)

Translation: project-15.0/project-15.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_sequence/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-16.0/project-16.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_sequence/
Currently translated at 100.0% (10 of 10 strings)

Translation: project-16.0/project-16.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_sequence/it/
Currently translated at 100.0% (10 of 10 strings)

Translation: project-16.0/project-16.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_sequence/de/
Currently translated at 100.0% (10 of 10 strings)

Translation: project-16.0/project-16.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_sequence/es/
Currently translated at 90.0% (9 of 10 strings)

Translation: project-16.0/project-16.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_sequence/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-16.0/project-16.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_sequence/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-17.0/project-17.0-project_sequence
Translate-URL: https://translation.odoo-community.org/projects/project-17-0/project-17-0-project_sequence/
Copy link

@BT-ojossen BT-ojossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small things to check.

project_sequence/data/ir_sequence.xml Outdated Show resolved Hide resolved
project_sequence/i18n/de.po Outdated Show resolved Hide resolved
project_sequence/i18n/es.po Outdated Show resolved Hide resolved
project_sequence/i18n/it.po Outdated Show resolved Hide resolved
project_sequence/i18n/nl.po Outdated Show resolved Hide resolved
@BT-mchechlacz BT-mchechlacz force-pushed the 18.0-mig-project_sequence branch from 6be8804 to caebc6c Compare November 20, 2024 22:48
Copy link

@coleste coleste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@BT-dmoreno BT-dmoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Dec 18, 2024

/ocabot migration project_sequence
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 18, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1370-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 18, 2024
10 tasks
@OCA-git-bot OCA-git-bot merged commit 4ce3840 into OCA:18.0 Dec 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4991e3c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.