-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] web_pivot_computed_measure: Migration to 18.0 #3005
[18.0][MIG] web_pivot_computed_measure: Migration to 18.0 #3005
Conversation
… custom_events addition [IMP] web_pivot_computed_measure: Time Ranges Comparison [FIX] web_pivot_computed_measure: Change custom_events addition Previous this commit, the controller events are discarted. With this commit the existing events are respected
Currently translated at 100.0% (20 of 20 strings) Translation: web-15.0/web-15.0-web_pivot_computed_measure Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_pivot_computed_measure/es/
…s operation error
b9ec9b3
to
9f039d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Tested and looking good. Just a tiny doubt
@@ -0,0 +1 @@ | |||
odoo-test-helper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should go in a commit appart from the migration one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrobaeza Can you show us the way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no problem in going on the same one, as in future migrations, the filter directory git command strips it out, and in fact it's somehow part of the migration. The pity is that this is not automatizable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the module, but I believe something isn’t working correctly. When grouping by a Many2one field (e.g., by Customer or Salesperson) in the columns:
Without a computed measure, the values are displayed correctly:
However, with a computed measure (e.g., Total - Taxes), the values appear empty:
Could you please check this?
9f039d7
to
83c38fa
Compare
@carlos-lopez-tecnativa thanks 4 the review :) It should be solved right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot migration web_pivot_computed_measure |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 974a2e0. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT51903
ping @chienandalu @carlos-lopez-tecnativa