Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] web_pivot_computed_measure: Migration to 18.0 #3005

Merged
merged 21 commits into from
Nov 29, 2024

Conversation

CarlosRoca13
Copy link
Contributor

Tardo and others added 20 commits November 26, 2024 14:06
… custom_events addition

[IMP] web_pivot_computed_measure: Time Ranges Comparison

[FIX] web_pivot_computed_measure: Change custom_events addition

Previous this commit, the controller events are discarted. With this commit
the existing events are respected
Currently translated at 100.0% (20 of 20 strings)

Translation: web-15.0/web-15.0-web_pivot_computed_measure
Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_pivot_computed_measure/es/
@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG-web_pivot_computed_measure branch 3 times, most recently from b9ec9b3 to 9f039d7 Compare November 28, 2024 07:31
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Tested and looking good. Just a tiny doubt

@@ -0,0 +1 @@
odoo-test-helper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should go in a commit appart from the migration one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza Can you show us the way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no problem in going on the same one, as in future migrations, the filter directory git command strips it out, and in fact it's somehow part of the migration. The pity is that this is not automatizable.

Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the module, but I believe something isn’t working correctly. When grouping by a Many2one field (e.g., by Customer or Salesperson) in the columns:

Without a computed measure, the values are displayed correctly:
image

However, with a computed measure (e.g., Total - Taxes), the values appear empty:
image

Could you please check this?

@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG-web_pivot_computed_measure branch from 9f039d7 to 83c38fa Compare November 29, 2024 10:03
@CarlosRoca13
Copy link
Contributor Author

@carlos-lopez-tecnativa thanks 4 the review :) It should be solved right now

Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot migration web_pivot_computed_measure
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 29, 2024
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3005-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 29, 2024
25 tasks
@OCA-git-bot OCA-git-bot merged commit 8e1f37d into OCA:18.0 Nov 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 974a2e0. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-MIG-web_pivot_computed_measure branch November 29, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants