Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download ECMWF SEAS51 data #5

Merged
merged 2 commits into from
Oct 27, 2023
Merged

download ECMWF SEAS51 data #5

merged 2 commits into from
Oct 27, 2023

Conversation

zackarno
Copy link
Collaborator

@zackarno zackarno commented Oct 23, 2023

This PR downloads all available historical ECMWF SEAS51 precipitation forecast data over the Central American Dry Corridor (CADC).

  • IMHO - there is not really much to review - perhaps just a quick look at the download script here : data-raw/ecmwf_seas51.R ? Think the exploration folder can be ignored in this PR
  • The reason I don't think it needs much review is because we are awaiting feedback from partners on which forecasts will be recommended (they are discussing national forecasts). Therefore the purpose of this branch was just to set up the template for scripts to download the ECMWF data if necessary and become somewhat familiar.
  • This being said, i'd like to merge it mainly for the purpose of pruning/cleaning branches in the repo and my mind :-).
  • This can be merged directly to the downstream branch (iri-vhi-trigger-simulation) or to main after iri-vhi-trigger-simulation is merged to main
  • For a little additional background info: The monthly ECMWF forecasts don't really fit into the current framework which is based on 3-month tercile probability forecasts. We are toying with the idea of calculating transforming these data to that format, but it's out of scope of this branch which is mainly just downloading.

@zackarno zackarno requested a review from caldwellst October 23, 2023 18:13
Copy link

@caldwellst caldwellst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just a few code comments but I think the download functionality works well! Good find on the R package too. All good to merge whenever you think ready, just address the comments as you see fit or not at all!

Base automatically changed from iri-vhi-trigger-simulation to main October 27, 2023 17:25
@zackarno zackarno merged commit 7d9dcff into main Oct 27, 2023
@zackarno zackarno deleted the download-ECMWF branch October 27, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants