Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-1692 fix admin2 ref logic, fix case when resource is deleted in operational presence, read admin 3 rows into operational presence #219

Merged
merged 5 commits into from
Jan 23, 2025
Merged

HDXDSYS-1692 fix admin2 ref logic, fix case when resource is deleted in operational presence, read admin 3 rows into operational presence #219

merged 5 commits into from
Jan 23, 2025

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Jan 23, 2025

No description provided.

@mcarans
SOme renaming of protected variables
c909174 
Add logic to enable op presence to not ignore admin 3 data
@mcarans
Allow for duplicates
93b2d8c
@mcarans
Fix adding dataset more than once
670f459
@mcarans
Allow admin 3 to be treated as admin 2 for operational presence - thi…
de04db0 
…s means there can be duplicates which must be ignored

Prevent issue where dataset updated after operational presence has run and the required resource is deleted
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Test Results

16 tests  +2   16 ✅ +2   36m 2s ⏱️ + 2m 6s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 084b66e. ± Comparison against base commit c74df0f.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Jan 23, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12921439606

Details

  • 126 of 132 (95.45%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 94.111%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hapi/pipelines/database/humanitarian_needs.py 6 7 85.71%
src/hapi/pipelines/database/operational_presence.py 28 33 84.85%
Files with Coverage Reduction New Missed Lines %
src/hapi/pipelines/database/operational_presence.py 1 92.0%
src/hapi/pipelines/database/humanitarian_needs.py 1 96.92%
Totals Coverage Status
Change from base Build 12917074941: -0.2%
Covered Lines: 1566
Relevant Lines: 1664
💛 - Coveralls

@mcarans mcarans requested a review from b-j-mills January 23, 2025 02:52
b-j-mills
b-j-mills approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@b-j-mills b-j-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mcarans mcarans merged commit 5a9374e into main Jan 23, 2025
3 checks passed
@mcarans mcarans mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-mills b-j-mills b-j-mills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcarans @coveralls @b-j-mills