Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-1314 HAPI conflict dataset #225

Merged
merged 10 commits into from
Feb 20, 2025
Merged

HDXDSYS-1314 HAPI conflict dataset #225

merged 10 commits into from
Feb 20, 2025

Conversation

b-j-mills
Copy link
Collaborator

Read from HAPI conflict dataset. I made sure the tests only read one resource to speed things up.

@b-j-mills b-j-mills requested a review from mcarans February 14, 2025 23:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 15, 2025 •
edited
Loading

Test Results

16 tests  ±0   16 ✅ ±0   25m 33s ⏱️ - 5m 52s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit fd557f0. ± Comparison against base commit e94051e.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Feb 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13441889738

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 93.666%
Files with Coverage Reduction New Missed Lines %
src/hapi/pipelines/utilities/provider_admin_names.py 2 82.35%
src/hapi/pipelines/app/pipelines.py 8 94.22%
Totals Coverage Status
Change from base Build 13424094493: -0.7%
Covered Lines: 1464
Relevant Lines: 1563
💛 - Coveralls

mcarans
mcarans approved these changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@mcarans mcarans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me and good that the test data is smaller

@b-j-mills b-j-mills merged commit fdda193 into main Feb 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarans mcarans mcarans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-j-mills @coveralls @mcarans