Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-1786 Update HAPI Pipelines HNO to read from HAPI dataset #227

Merged
merged 3 commits into from
Feb 19, 2025
Merged

HDXDSYS-1786 Update HAPI Pipelines HNO to read from HAPI dataset #227

merged 3 commits into from
Feb 19, 2025

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Feb 19, 2025

No description provided.

@mcarans mcarans requested a review from b-j-mills February 19, 2025 04:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

Test Results

16 tests  ±0   16 ✅ ±0   32m 7s ⏱️ +34s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit bc99243. ± Comparison against base commit a291078.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Feb 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13420927047

Details

  • 87 of 92 (94.57%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.328%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hapi/pipelines/database/hapi_dataset_uploader.py 70 75 93.33%
Totals Coverage Status
Change from base Build 13400060234: 0.02%
Covered Lines: 1530
Relevant Lines: 1622
💛 - Coveralls

b-j-mills
b-j-mills approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@b-j-mills b-j-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It'll really cut down on the amount of code we have to write.

@b-j-mills
Copy link
Collaborator

Ah, the only thing missing is the changelog, otherwise ready to merge!

@mcarans mcarans merged commit e94051e into main Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-mills b-j-mills b-j-mills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcarans @coveralls @b-j-mills