Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-1312 hapi idps #228

Merged
merged 3 commits into from
Feb 21, 2025
Merged

HDXDSYS-1312 hapi idps #228

merged 3 commits into from
Feb 21, 2025

Conversation

b-j-mills
Copy link
Collaborator

Read from HAPI IDPs dataset. I'm considering cutting down the test csv.

@b-j-mills b-j-mills requested a review from mcarans February 20, 2025 21:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Test Results

16 tests  ±0   16 ✅ ±0   24m 40s ⏱️ -51s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9e5c33c. ± Comparison against base commit fdda193.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Feb 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13448551714

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 93.623%
Files with Coverage Reduction New Missed Lines %
src/hapi/pipelines/utilities/process_config_defaults.py 1 97.62%
Totals Coverage Status
Change from base Build 13444671219: -0.04%
Covered Lines: 1424
Relevant Lines: 1521
💛 - Coveralls

mcarans
mcarans approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@mcarans mcarans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mcarans
Copy link
Contributor

mcarans commented Feb 21, 2025

Needs changelog

@mcarans
Copy link
Contributor

mcarans commented Feb 21, 2025 •
edited
Loading

If it runs in a minute or so rather than say 10 or 15 minutes and the file is not too large eg. <10Mb then no need to cut down the test file

@b-j-mills b-j-mills merged commit c9ed5ab into main Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarans mcarans mcarans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-j-mills @coveralls @mcarans