Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hapi population dataset #229

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Hapi population dataset #229

merged 2 commits into from
Feb 21, 2025

Conversation

b-j-mills
Copy link
Collaborator

Read from HAPI dataset. Tests have been cut down by a lot.

@b-j-mills b-j-mills requested a review from mcarans February 21, 2025 00:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

Test Results

16 tests  ±0   16 ✅ ±0   25m 33s ⏱️ +2s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f26aa6f. ± Comparison against base commit fdda193.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 13447472647

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 93.462%
Totals Coverage Status
Change from base Build 13444671219: -0.2%
Covered Lines: 1401
Relevant Lines: 1499
💛 - Coveralls

mcarans
mcarans approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@mcarans mcarans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Needs a changelog update. Good that you cut down the test data.

@b-j-mills b-j-mills merged commit 8967bbc into main Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarans mcarans mcarans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-j-mills @mcarans