Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDXDSYS-1796 Update HAPI Pipelines poverty rate to read from HAPI dataset #230

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Feb 24, 2025

@b-j-mills This also updates the hapi_populate method to allow passing max_admin_level so can now handle admin levels < 2 (but defaults to 2).

@mcarans mcarans requested a review from b-j-mills February 24, 2025 03:16
Copy link

github-actions bot commented Feb 24, 2025

Test Results

16 tests  ±0   16 ✅ ±0   24m 16s ⏱️ -4s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit bffe534. ± Comparison against base commit c9ed5ab.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13490036651

Details

  • 20 of 21 (95.24%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 92.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hapi/pipelines/database/hapi_dataset_uploader.py 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
src/hapi/pipelines/database/admins.py 3 93.3%
Totals Coverage Status
Change from base Build 13486907848: -0.4%
Covered Lines: 1304
Relevant Lines: 1409

💛 - Coveralls

Copy link
Collaborator

@b-j-mills b-j-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -20,5 +20,5 @@ def populate(self) -> None:
self.hapi_populate(
"conflict-event",
DBConflictEvent,
end_resource=29,
end_resource=None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@b-j-mills b-j-mills merged commit 7ee5261 into main Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants