Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-1310 HAPI refugees returnees #231

Merged
merged 4 commits into from
Feb 25, 2025
Merged

HDXDSYS-1310 HAPI refugees returnees #231

merged 4 commits into from
Feb 25, 2025

Conversation

b-j-mills
Copy link
Collaborator

I had to edit the dataset uploader to include the locations for admin 0 data, and alter it slightly to allow multiple non-standard location codes.

@b-j-mills b-j-mills requested a review from mcarans February 25, 2025 15:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

Test Results

17 tests  +1   17 ✅ +1   12m 26s ⏱️ - 11m 57s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e9f1875. ± Comparison against base commit f8dba95.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
tests.test_main.TestHAPIPipelines ‑ test_refugees_and_returnees[themes_to_run0]

tests.test_main.TestHAPIPipelines ‑ test_refugees[themes_to_run0]
tests.test_main.TestHAPIPipelines ‑ test_returnees[themes_to_run0]

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Feb 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13524873831

Details

  • 55 of 55 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 92.55%
Totals Coverage Status
Change from base Build 13507837864: 0.002%
Covered Lines: 1292
Relevant Lines: 1396
💛 - Coveralls

mcarans
mcarans approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@mcarans mcarans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Glad the tests are faster!

@b-j-mills b-j-mills merged commit 45cffa0 into main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarans mcarans mcarans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-j-mills @coveralls @mcarans