Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAPI-142 HAPI-143 Humanitarian Needs theme: Add 3 countries to pipeline #67

Merged
merged 6 commits into from
Jan 4, 2024
Merged

HAPI-142 HAPI-143 Humanitarian Needs theme: Add 3 countries to pipeline #67

merged 6 commits into from
Jan 4, 2024

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Dec 21, 2023

No description provided.

@mcarans mcarans changed the title Add humanitarian needs HAPI-142 Humanitarian Needs theme: Add a single country to pipeline Dec 21, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

Test Results

4 tests  ±0   4 ✅ ±0   3m 17s ⏱️ +47s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 559a1cf. ± Comparison against base commit 617863f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7403130713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 92.841%
Totals Coverage Status
Change from base Build 7242395812: 0.6%
Covered Lines: 843
Relevant Lines: 908
💛 - Coveralls

@mcarans mcarans requested a review from b-j-mills December 21, 2023 03:39
@mcarans mcarans marked this pull request as draft December 22, 2023 04:51
b-j-mills
b-j-mills approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@b-j-mills b-j-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is an incredible amount of work! I'm concerned about the manual work of inputting all the column names, but if the datasets are stable and similar at least it wouldn't need to be done very often (and there probably isn't a good way around it).

@mcarans
Copy link
Contributor Author

mcarans commented Jan 4, 2024

@b-j-mills Yes, the amount of manual work may not be sustainable as I expect that the formats are not stable year on year. I discussed with CJ and will propose to DP that we approach the country offices with our own spreadsheet format to see if we can encourage adoption.

@mcarans mcarans marked this pull request as ready for review January 4, 2024 01:01
@mcarans mcarans changed the title HAPI-142 Humanitarian Needs theme: Add a single country to pipeline HAPI-142 HAPI-143 Humanitarian Needs theme: Add a single country to pipeline Jan 4, 2024
@mcarans mcarans changed the title HAPI-142 HAPI-143 Humanitarian Needs theme: Add a single country to pipeline HAPI-142 HAPI-143 Humanitarian Needs theme: Add 3 countries to pipeline Jan 4, 2024
@mcarans mcarans merged commit 9388975 into main Jan 4, 2024
3 checks passed
@turnerm turnerm deleted the humanitarian_needs branch May 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-mills b-j-mills b-j-mills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcarans @b-j-mills