Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-680 Remove Github patch stuff #82

Merged
merged 4 commits into from
Apr 26, 2024
Merged

HDXDSYS-680 Remove Github patch stuff #82

merged 4 commits into from
Apr 26, 2024

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Apr 24, 2024

No description provided.

@mcarans mcarans changed the title Remove Github patch stuff HDXDSYS-680 Remove Github patch stuff Apr 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Test Results

4 tests   - 1   4 ✅  - 1   4m 54s ⏱️ -4s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5e74fc1. ± Comparison against base commit d50a9a7.

This pull request removes 1 test. 
tests.test_hapi_patch.TestHAPIPatch ‑ test_hapi_patch

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Apr 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8842105675

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 91.837%
Files with Coverage Reduction New Missed Lines %
src/hapi/pipelines/database/admins.py 2 89.22%
Totals Coverage Status
Change from base Build 8745876735: -0.7%
Covered Lines: 945
Relevant Lines: 1029
💛 - Coveralls

@mcarans mcarans requested review from turnerm and b-j-mills April 24, 2024 04:42
turnerm
turnerm approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@turnerm turnerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such beautiful work, a shame to remove! Maybe wait to merge until the meeting with Emma on Thursday to confirm that we can actually execute pivot plan A. And don't forget the changelog ;)

@ccataalin ccataalin mentioned this pull request Apr 25, 2024
Closed
mcarans added 3 commits April 26, 2024 12:49
@mcarans
Update CHANGELOG
1e7fddf 
Update precommit config
Use material theme for docs
@mcarans
Fix test
ae079e1
@mcarans
Test works locally
5e74fc1
@mcarans mcarans merged commit 6c320bb into main Apr 26, 2024
3 checks passed
@turnerm turnerm deleted the remove_patch branch May 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turnerm turnerm turnerm approved these changes

@b-j-mills b-j-mills b-j-mills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcarans @coveralls @turnerm @b-j-mills