Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-685 Output csvs #83

Merged
merged 13 commits into from
Apr 30, 2024
Merged

HDXDSYS-685 Output csvs #83

merged 13 commits into from
Apr 30, 2024

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Apr 29, 2024 •
edited
Loading

Works now (thanks to Alex)

@mcarans mcarans marked this pull request as draft April 29, 2024 06:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

Test Results

4 tests  ±0   4 ✅ ±0   5m 18s ⏱️ +16s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 6901862. ± Comparison against base commit 6c320bb.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8902683646

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.837%
Totals Coverage Status
Change from base Build 8842274140: 0.0%
Covered Lines: 945
Relevant Lines: 1029
💛 - Coveralls

mcarans and others added 3 commits April 30, 2024 06:28
@mcarans
Try mapping /tmp
e49aed0
@mcarans
Change back
353a05d
@alexandru-m-g
PR csv output (#84)
60ba7a5 
* Running dump_views.sh from host

* Making the script executable

* running the script under bash
@mcarans mcarans requested a review from turnerm April 29, 2024 20:22
@mcarans mcarans marked this pull request as ready for review April 29, 2024 21:06
turnerm
turnerm approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@turnerm turnerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fighting with docker!

@mcarans
Make changes from Monica
6901862 
Dump all tables
Remove - from hash files
USe subfolder for csv
@mcarans mcarans merged commit 3181fd5 into main Apr 30, 2024
4 checks passed
@turnerm turnerm deleted the csv_output branch May 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turnerm turnerm turnerm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcarans @coveralls @turnerm @alexandru-m-g