Memory Leak in CsdlReader.TryParse Due to missing xmlns=”http://docs.oasis-open.org/odata/ns/edm”

[WanjohiSammy]

The CsdlReader.TryParse does not throw an exception when parsing CSDL document with missing xmlns=”http://docs.oasis-open.org/odata/ns/edm”. Instead, the memory continuously increases until it reaches the maximum limit, resulting in significant memory usage. This condition persists until the operation is either forcibly stopped, canceled, or time out.

Assemblies affected

Microsoft.OData.Edm 7.x, 8.x

Reproduce steps

• Clone the repo: https://github.com/WanjohiSammy/MemoryLeakInCSDLReaderTryParse.git

• Run the application:

  • Remove xmlns="http://docs.oasis-open.org/odata/ns/edm" from the Schema tag and run the application

  <edmx:Edmx xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx" Version="4.0">
   <edmx:DataServices>
       <Schema Namespace="NS"> // without xmlns="http://docs.oasis-open.org/odata/ns/edm"
           <EntityType Name="Customer">
               <Key>
                   <PropertyRef Name="Id" />
               </Key>
               <Property Name="Id" Type="Edm.Int32" Nullable="false" />
               <Property Name="Name" Type="Edm.String" />
           </EntityType>
           <EntityContainer Name="Container">
               <EntitySet Name="Customers" EntityType="NS.Customer" />
           </EntityContainer>
       </Schema>
   </edmx:DataServices>
  </edmx:Edmx>

  • Note how the process memory is growing using Visual Studio Diagnostics Tools

  

  • with <Schema xmlns=""http://docs.oasis-open.org/odata/ns/edm"" Namespace=""NS"">, the CSDL document is parsed successfully

  <edmx:Edmx xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx" Version="4.0">
   <edmx:DataServices>
       <Schema xmlns="http://docs.oasis-open.org/odata/ns/edm" Namespace="NS"> // with xmlns
           <EntityType Name="Customer">
               <Key>
                   <PropertyRef Name="Id" />
               </Key>
               <Property Name="Id" Type="Edm.Int32" Nullable="false" />
               <Property Name="Name" Type="Edm.String" />
           </EntityType>
           <EntityContainer Name="Container">
               <EntitySet Name="Customers" EntityType="NS.Customer" />
           </EntityContainer>
       </Schema>
   </edmx:DataServices>
  </edmx:Edmx>

Expected result

Schema without xmlns="http://docs.oasis-open.org/odata/ns/edm" should throw an exception or should be captured as part of EdmError instead of running to forever and increases memory usage.

Actual result

The memory continuously increases until it reaches the maximum limit, resulting in significant memory usage. This condition persists until the operation is either forcibly stopped, canceled, or time out.

Additional detail

Optional, details of the root cause if known. Delete this section if you have no additional details to add.