Performance data are wrong

[anayrat]

I open this issue in order to not forget it :)

Performance data are wrong (at least with temp_files service):

check_pgactivity --status-file /var/lib/postgresql/check_pgactivity.data -F human -s temp_files   -w '10,500m' -c '50,5G'
Service        : POSTGRES_TEMP_FILES
Returns        : 0 (OK)
Message        : 4 tablespace(s)/database(s) checked
Perfdata       : postgres=0Fpm
Perfdata       : postgres=0Bpm
Perfdata       : postgres=0Files warn=500 crit=5
Perfdata       : postgres=0B

Expect to have warn=10 crit=50 on # files and warn=500m crit=5G on file size.

Regards,

[anayrat]

I completely forgot this issue.
The problem is the "b" is missing in the unit:

-'10,500m'
+'10,500mb'

We should fix the documentation:

If THRESHOLD is a size, the following units are accepted (not case sensitive): b (Byte), k (KB), m (MB), g (GB), t (TB), p (PB), e (EB) or Z (ZB). Only integers are accepted. Eg. 1.5MB will be refused, use 1500kB.

To:

If THRESHOLD is a size, the following units are accepted (not case sensitive): b (Byte), kb (KB), mb (MB), gb (GB), tb (TB), pb (PB), eb (EB) or zb (ZB). Only integers are accepted. Eg. 1.5MB will be refused, use 1500kB.

I try to add a test in order to trigger an error if the format is not respected (\d+)(,\d+[kmgtpez]?b)?. But I wasn't able to add such test without breaking the while :(

check_pgactivity/check_pgactivity

Line 8471 in 80b26f9

while ( $args{'warning'} =~ m/(?:(\d+)([kmgtpez]?b)?)/ig ) {