Fix error when switching data on already trained model

New dataset didn't have the predictions column yet which errored when
trying to serialize and send to anchorviz. Fixed by adding a
"data_changed" event that the model class listens for and calls `fit()`

Author: WarmCyan

icat/data.py

@@ -295,6 +295,7 @@ def __init__(
         self._data_label_callbacks: list[Callable] = []
         self._row_selected_callbacks: list[Callable] = []
         self._sample_changed_callbacks: list[Callable] = []
+        self._data_changed_callbacks: list[Callable] = []
 
         super().__init__(**params)  # required for panel components
         # Note that no widgets can be declared _after_ the above, or their values won't be
@@ -452,6 +453,14 @@ def on_row_selected(self, callback: Callable):
         """
         self._row_selected_callbacks.append(callback)
 
+    def on_data_changed(self, callback: Callable):
+        """Register a callback function for the "data changed" event, when the
+        active_data dataframe is switched out.
+
+        Callbacks for this event should take no parameters.
+        """
+        self._data_changed_callbacks.append(callback)
+
     @param.depends("sample_indices", watch=True)
     def fire_on_sample_changed(self):
         for callback in self._sample_changed_callbacks:
@@ -465,6 +474,10 @@ def fire_on_row_selected(self, index: int):
         for callback in self._row_selected_callbacks:
             callback(index)
 
+    def fire_on_data_changed(self):
+        for callback in self._data_changed_callbacks:
+            callback()
+
     # ============================================================
     # INTERNAL FUNCTIONS
     # ============================================================
@@ -698,6 +711,8 @@ def set_data(self, data: pd.DataFrame):
         if self.label_col not in self.active_data:
             self.active_data[self.label_col] = -1
 
+        self.fire_on_data_changed()
+
         self.set_random_sample()
         # TODO: seems weird to handle this here
         self._apply_filters()

icat/model.py

@@ -80,6 +80,7 @@ def __init__(
         self.anchor_list.on_anchor_removed(self._on_anchor_remove)
         self.anchor_list.on_anchor_changed(self._on_anchor_change)
         self.data.on_data_labeled(self._on_data_label)
+        self.data.on_data_changed(self._on_data_changed)
         self.view.on_selected_points_change(self._on_selected_points_change)
 
         self._last_anchor_names: dict[str, str] = []
@@ -88,6 +89,11 @@ def __init__(
 
         self.anchor_list.build_tfidf_features()
 
+    def _on_data_changed(self):
+        """Event handler for when set_data in datamanager is called."""
+        # self.data.active_data = self.featurize(self.data.active_data, normalize=False)
+        self.fit()
+
     def _on_data_label(self, index: int | list[int], new_label: int | list[int]):
         """Event handler for datamanager.