-
-
Notifications
You must be signed in to change notification settings - Fork 699
V10 section texts #2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Nitpick, the OAuth client does not always authenticates itself using a
|
Small change:
|
Can we just say:
Does the rest of the sentence bring much value? or maybe:
or
|
The context here is a bit different, it is definition what is a public client:
|
I numerated the points, Point 1 is still something to discuss and the rest is as quoted below. Point 1 - see #2896 (comment) - ping @randomstuff Point 2
Point 3
Point 4
|
My point was that in,
we assert that the confidential client authenticates itself using a client_secret. This is not always true as the client authenticate itself using another form of credentials. This is reflected by the definition of the public client:
"credentials" is more general than "client_secret" (as the former includes for example private keys while the latter is only a shared secret). (That is a very nitpicky detail about the text though.) |
In the Authorization Code Flow, the client application only needs a client_id during the initial, user-driven request, even for confidential clients. I think that distinction is important. The client_secret is purposefully omitted in this first hop - again - even for confidential clients. Only the second and third hop of the authorization code flow (the back-channel requests) require a client secret. Hop 2 - The exchange of the authorization code for tokens—requires a client_id and client_secret. I just think this is interesting. :) Please ignore if it hurts the flow of this conversation, no pun intended. |
Point 1 Ok, got the point. Current text in chapter text:
Proposal based on feedback from @randomstuff
Note that I changed "typically" to "e.g.," as I don't have any arguments or reason to state that this is typical and will stay "typical", and it is not well aligned with strong authentication requirements. |
Client_id is not a client secret, it's a public client identifier. The phrase "client secrets (e.g., using 'client_id' and a 'client_secret' parameters)" makes no sense. I would suggest: A public client is not capable of maintaining the confidentiality of credentials for authenticating with the authorization server. Therefore, instead of authenticating itself using client secrets (e.g., using the 'client_secret' parameter), it only identifies itself as a client (using a 'client_id'). or maybe just: A public client is not capable of maintaining the confidentiality of credentials for authenticating with the authorization server. Therefore, instead of authenticating itself using 'client_id' and 'client_secret' parameters, it only identifies itself as a client using a 'client_id'. or perhaps: A public client is not capable of maintaining the confidentiality of credentials for authenticating with the authorization server. Therefore, instead of authenticating itself using 'client_id' and 'client_secret' parameters, it only identifies itself using a 'client_id'. I like the last one better. |
What about
|
As we are in the beginning of intro text with this phrase, I put all the parameters "away" to brackets:
|
This looks solid. Nice work folks. |
Topic 1
Control Objective
Maybe
Topic 2
Propose to ignore the Appendix A link here.
Topic 3
I think the commas are incorrect (or at least confusing) here
Topic 4
V10.1 Generic OAuth and OIDC security
A bit hard to read. Maybe it can be split into 2 sentences
The text was updated successfully, but these errors were encountered: