[Abandoned Plugin] OctoPrint-Prusa-Mini-ETA

[sarusani]

Which Plugin?

https://plugins.octoprint.org/plugins/prusa_mini_eta/

Link to ticket on plugin's issue tracker confirming abandonment

vookimedlo/OctoPrint-Prusa-Mini-ETA#6

Is there someone open to adopting it?

No response

[jneilliii]

It appears that an open PR on the original repo may resolve the issue linked here. Maybe @egguy would be up for adoption?

[egguy]

I would be OK to adopt the plugin. Should I do a fork of the repo and change the .md ?

[cp2004]

Is there a difference between the aforementioned plugin and this one? https://plugins.octoprint.org/plugins/m73etaoverride/

[SB97]

@cp2004 just looked at the source code of both. They have the same functionality. And It looks like neither of those do support the silent mode in PrusaSlicer.

[egguy]

There's an unmerged PR to have the estimated time from the initial gcode loading, which is already present in this plugin.
@SB97 If there's a way to detect if the printer is in silent mode, I could try to implement. (there's also a separate branch with this functionality, but unfinished)

[SB97]

@egguy i only can find gcode to set it. prusa3d/Prusa-Firmware#58
maybe it could be shown on hover or something when someone is interested in the silent time.

[egguy]

Ok, I've implemented a support for the silent mode of the Prusa MK3, but it requires activating the functionality in the plugin's settings.
I think the plugin should work with other printers, but I can't test :s

[jneilliii]

I would be OK to adopt the plugin. Should I do a fork of the repo and change the .md ?

The process is fairly easy. You just submit a PR adding you to the authors list in the md file, and preferably the overlays for the update checks. You'll want to finalize any changes and bump the version in setup.py and create a release in GitHub with the same version as the tag. Here's an example of a recent adoption: https://github.com/OctoPrint/plugins.octoprint.org/pull/1027/files

[jneilliii]

but agree with @cp2004 if the other plugin does the same thing and is still active it would probably be better to retire one and keep the other. There may have been a technical difference to how the plugins were functioning, but further review would need to be made for that.

[jneilliii]

I remember now why there are two. Prusa-Mini-ETA also includes an analysis factory, whereas M73ETAOverride is just an estimation factory.