Add tests

Author: tersmitten

README.md

@@ -14,6 +14,8 @@ Set up Node Version Manager ([nvm](https://github.com/nvm-sh/nvm)) in Debian-lik
 
 * `nvm_version` [default: `v0.40.2`]: Version to install
 * `nvm_install` [default: `[]`]: (Additional) packages to install (e.g. `build-essential`, `libssl-dev`)
+* `nvm_user` [default: `root`]: The user to install nvm for (you want this to be something different than `root`)
+* `nvm_shell` [default: `/bin/bash`]: The shell to use to install nvm (changing this to something different is not tested (yet))
 
 ## Dependencies
 

defaults/main.yml

@@ -1,5 +1,6 @@
 # defaults file
 ---
 nvm_version: 'v0.40.2'
-
 nvm_install: []
+nvm_user: root
+nvm_shell: /bin/bash

molecule/default/verify.yml

@@ -2,4 +2,6 @@
 - name: Verify
   hosts: all
   become: true
-  tasks: []
+  tasks:
+    - name: include tasks
+      ansible.builtin.import_tasks: "{{ playbook_dir }}/../../tests/tasks/post.yml"

tasks/main.yml

@@ -28,7 +28,7 @@
     - nvm
     - nvm-install
   become: true
-  become_user: "{{ nvm_user | default('root') }}"
+  become_user: "{{ nvm_user }}"
   block:
     - name: install | nvm | get current version  # noqa command-instead-of-module
       ansible.builtin.shell: >
@@ -41,7 +41,9 @@
 
     - name: install | nvm | install given version  # noqa command-instead-of-module risky-shell-pipe
       ansible.builtin.shell: >
-        curl -sSL https://raw.githubusercontent.com/nvm-sh/nvm/{{ nvm_version }}/install.sh | bash -
+        curl -sSL https://raw.githubusercontent.com/nvm-sh/nvm/{{ nvm_version }}/install.sh | {{ nvm_shell }} -
+      args:
+        executable: "{{ nvm_shell }}"
       environment:
         PROFILE: /dev/null
       changed_when: true

tests/tasks/post.yml

@@ -1,34 +1,15 @@
 # post test file
 ---
-- name: install dependencies  # noqa package-latest
-  ansible.builtin.apt:
-    name:
-      - curl
-    state: latest
-    update_cache: true
-    cache_valid_time: "{{ apt_update_cache_valid_time | default(3600) }}"
-
-- name: test installation  # noqa command-instead-of-module risky-shell-pipe
-  ansible.builtin.command: >
-    echo 'console.log("PING".replace("I", "O"));'
-    | nodejs
-    | grep -q 'PONG'
-    && (echo 'Availability test: pass' && exit 0)
-    || (echo 'Availability test: fail' && exit 1)
-  register: _result
-  changed_when: false
-  tags:
-    - skip_ansible_lint
-
-- name: run tests
-  ansible.builtin.command: >
-    {{ item }}
-  changed_when: false
-  with_items:
-    # Ensure Node.js is installed
-    - which node
-    - node -v
-
-    # Ensure npm packages are installed globally
-    - npm list -g --depth=0 jslint
-    - npm list -g --depth=0 yo
+- name: post | install
+  become: true
+  become_user: "{{ nvm_user }}"
+  block:
+    - name: post | install | test  # noqa command-instead-of-module risky-shell-pipe
+      ansible.builtin.shell: >
+        export NVM_DIR=~/.nvm;
+        source "${NVM_DIR}/nvm.sh" && command -v nvm;
+      args:
+        executable: "{{ nvm_shell }}"
+      register: _result
+      changed_when: false
+      failed_when: _result.stdout != 'nvm'

tests/test.yml

@@ -6,3 +6,6 @@
   become: true
   roles:
     - ../../
+  post_tasks:
+    - name: include tasks
+      ansible.builtin.import_tasks: "{{ playbook_dir }}/tasks/post.yml"

tests/vagrant.yml

@@ -9,3 +9,6 @@
       nvm_version: 'v0.40.1'
     - role: ../../
       nvm_user: vagrant
+  post_tasks:
+    - name: include tasks
+      ansible.builtin.import_tasks: "{{ playbook_dir }}/tasks/post.yml"